Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the date filter in Europeana to pull updates rather than created records #2817

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Adjust the date filter in Europeana to pull updates rather than created records #2817

merged 2 commits into from
Aug 15, 2023

Conversation

rwidom
Copy link
Collaborator

@rwidom rwidom commented Aug 11, 2023

Fixes

Fixes #1268 by @stacimc

Description

We've been filtering on image create date, rather than update date. Hopefully this switch will both smooth out the number of records processed in regular dag runs, and make re-ingestion either unnecessary or substantially less necessary.

I thought it would be helpful to have this in place for testing #2782

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@rwidom rwidom requested a review from a team as a code owner August 11, 2023 09:28
@rwidom rwidom requested review from krysal and stacimc August 11, 2023 09:28
@github-actions github-actions bot added the 🧱 stack: catalog Related to the catalog and Airflow DAGs label Aug 11, 2023
@openverse-bot openverse-bot added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Aug 11, 2023
stacimc
stacimc approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! It would be great to drop the reingestion workflow.

I tried running Europeana for 2023-07-28 and it pulled 13 images on main, but I stopped it early after ingesting >7,500 on this branch! Noting that we may see increased Europeana runtimes with this (which is good and to be expected 😄)

obulat
obulat approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works well 🎉
I had to manually set the date parameter in the ProviderDataIngester class, though, because I couldn't adjust the date for the DAG run, changing start_date

openverse/catalog/dags/providers/provider_workflows.py

Line 205 in f323231

start_date=datetime(2022, 10, 27),
didn't work.

@obulat obulat merged commit 1024974 into main Aug 15, 2023
@obulat obulat deleted the fix-1268/europeana-pulls-updates-not-creates branch August 15, 2023 11:30
@AetherUnbound AetherUnbound mentioned this pull request Aug 16, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacimc stacimc stacimc approved these changes

@obulat obulat obulat approved these changes

@krysal krysal Awaiting requested review from krysal krysal is a code owner automatically assigned from WordPress/openverse-catalog

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Europeana to ingest by timestamp_updated
4 participants
@rwidom @obulat @stacimc @openverse-bot